linux-kernel - Re: [PATCH] rseq: Delete duplicate if statement in rseq_virt_userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v7j75qwz.ffs@tglx>
Date: Tue, 18 Nov 2025 15:58:04 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: "Peter Zijlstra (Intel)" <peterz@...radead.org>, Ingo Molnar
 <mingo@...nel.org>, Simon Schuster <schuster.simon@...mens-energy.com>,
 linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] rseq: Delete duplicate if statement in
 rseq_virt_userspace_exit()

On Tue, Nov 18 2025 at 13:52, Dan Carpenter wrote:
> This if statement is indented weirdly.  It's a duplicate and doesn't
> affect runtime (beyond wasting a little time).  Delete it.

It's actually optimized out by the compiler in both cases, but yes
that's an odd one and likely a reject fixup artifact.

Thanks for detecting it!