linux-kernel - RE: [PATCH v2 net-next 3/5] net: fec: remove struct fec_enet_priv_txrx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB8510819C0031952B303F05D088D6A@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Tue, 18 Nov 2025 01:59:57 +0000
From: Wei Fang <wei.fang@....com>
To: Frank Li <frank.li@....com>
CC: Shenwei Wang <shenwei.wang@....com>, Clark Wang <xiaoning.wang@....com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>, "pabeni@...hat.com" <pabeni@...hat.com>,
	"eric@...int.com" <eric@...int.com>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 net-next 3/5] net: fec: remove struct
 fec_enet_priv_txrx_info

> On Mon, Nov 17, 2025 at 06:19:19PM +0800, Wei Fang wrote:
> > The struct fec_enet_priv_txrx_info has three members: offset, page and
> > skb. The offset is only initialized in the driver and is not used, the
> > skb is never initialized and used in the driver. The both will not be
> > used in the future. Therefore, replace struct fec_enet_priv_txrx_info
> > bedirectly with struct page.
> 
> directly?

Thanks for catching this, I will fix it.

> 
> Reviewed-by: Frank Li <Frank.Li@....com>
>