linux-kernel - Re: [PATCH 3/3] mm/zswap: use %pe to print PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dqmiid7ep4b7lchv6qwniedftoqzo6qit5py3dwo6whrcljrbr@kydq6avtuypd>
Date: Tue, 18 Nov 2025 15:46:26 +0000
From: Yosry Ahmed <yosry.ahmed@...ux.dev>
To: Sahil Chandna <chandna.sahil@...il.com>
Cc: akpm@...ux-foundation.org, david@...hat.com, 
	lorenzo.stoakes@...cle.com, mhocko@...e.com, vbabka@...e.cz, rppt@...nel.org, 
	surenb@...gle.com, hannes@...xchg.org, shakeel.butt@...ux.dev, 
	zhengqi.arch@...edance.com, Liam.Howlett@...cle.com, weixugc@...gle.com, 
	axelrasmussen@...gle.com, yuanchu@...gle.com, nphamcs@...il.com, chengming.zhou@...ux.dev, 
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] mm/zswap: use %pe to print PTR_ERR() values

On Tue, Nov 18, 2025 at 11:38:51AM +0530, Sahil Chandna wrote:
> Use the %pe printk format specifier to report error pointers directly
> instead of printing PTR_ERR() as a long value. This improves clarity,
> produces more readable error messages.
> 
> This instance was flagged by the Coccinelle script
> (misc/ptr_err_to_pe.cocci) as an opportunity to adopt %pe.
> 
> Found by: make coccicheck MODE=report M=mm/
> No functional change intended.
> 
> Signed-off-by: Sahil Chandna <chandna.sahil@...il.com>

Acked-by: Yosry Ahmed <yosry.ahmed@...ux.dev>

> ---
>  mm/zswap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/zswap.c b/mm/zswap.c
> index c1af782e54ec..c35604db32ad 100644
> --- a/mm/zswap.c
> +++ b/mm/zswap.c
> @@ -749,8 +749,8 @@ static int zswap_cpu_comp_prepare(unsigned int cpu, struct hlist_node *node)
>  
>  	acomp = crypto_alloc_acomp_node(pool->tfm_name, 0, 0, cpu_to_node(cpu));
>  	if (IS_ERR(acomp)) {
> -		pr_err("could not alloc crypto acomp %s : %ld\n",
> -				pool->tfm_name, PTR_ERR(acomp));
> +		pr_err("could not alloc crypto acomp %s : %pe\n",
> +				pool->tfm_name, acomp);
>  		ret = PTR_ERR(acomp);
>  		goto fail;
>  	}
> -- 
> 2.50.1
>