linux-kernel - Re: [PATCH iproute2-next 1/2] devlink: Pull the value printing logic out of pr_out_param

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251118080239.405507d6@phoenix.local>
Date: Tue, 18 Nov 2025 08:02:39 -0800
From: Stephen Hemminger <stephen@...workplumber.org>
To: Daniel Zahka <daniel.zahka@...il.com>
Cc: Jiri Pirko <jiri@...nulli.us>, "David S. Miller" <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Simon
 Horman <horms@...nel.org>, Donald Hunter <donald.hunter@...il.com>, David
 Ahern <dsahern@...nel.org>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH iproute2-next 1/2] devlink: Pull the value printing
 logic out of pr_out_param_value()

On Mon, 17 Nov 2025 16:40:02 -0800
Daniel Zahka <daniel.zahka@...il.com> wrote:

> -			print_uint(PRINT_ANY, "value", " value %u",
> +			snprintf(format_str, sizeof(format_str), " %s %%u", label);
> +			print_uint(PRINT_ANY, label, format_str,

The problem with generating format strings is that it makes it difficult to
impossible to use any of the compiler format validation flags.