[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <aRyYPnn7H/+y+OEA@lizhi-Precision-Tower-5810>
Date: Tue, 18 Nov 2025 11:01:02 -0500
From: Frank Li <Frank.li@....com>
To: Haibo Chen <haibo.chen@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: imx943-evk: add flexcan support
On Tue, Nov 18, 2025 at 03:09:24PM +0800, Haibo Chen wrote:
> Add flexcan2 and flexcan4, and related phys support.
>
> Signed-off-by: Haibo Chen <haibo.chen@....com>
> ---
> arch/arm64/boot/dts/freescale/imx943-evk.dts | 43 ++++++++++++++++++++++++++++
> 1 file changed, 43 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx943-evk.dts b/arch/arm64/boot/dts/freescale/imx943-evk.dts
> index c8c3eff9df1a23c52e74bf2bc5d4ba543bb5a65b..9b2fce25532fa0dbca3a14041399adec0f753e68 100644
> --- a/arch/arm64/boot/dts/freescale/imx943-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx943-evk.dts
> @@ -34,6 +34,22 @@ dmic: dmic {
> #sound-dai-cells = <0>;
> };
>
> + flexcan2_phy: can-phy0 {
> + compatible = "nxp,tjr1443";
> + #phy-cells = <0>;
> + max-bitrate = <8000000>;
> + enable-gpios = <&pcal6416_i2c6_u50 3 GPIO_ACTIVE_HIGH>;
> + standby-gpios = <&pcal6416_i2c6_u50 4 GPIO_ACTIVE_LOW>;
> + };
> +
> + flexcan4_phy: can-phy1 {
> + compatible = "nxp,tjr1443";
> + #phy-cells = <0>;
> + max-bitrate = <8000000>;
> + enable-gpios = <&pcal6416_i2c3_u171 0 GPIO_ACTIVE_HIGH>;
> + standby-gpios = <&pcal6416_i2c3_u171 1 GPIO_ACTIVE_LOW>;
> + };
> +
Is it orderred? can-phy0 should be before dmic: dmic. (use nodename order).
Frank
> reg_usdhc2_vmmc: regulator-usdhc2 {
> compatible = "regulator-fixed";
> off-on-delay-us = <12000>;
> @@ -127,6 +143,20 @@ memory@...00000 {
> };
> };
>
> +&flexcan2 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flexcan2>;
> + phys = <&flexcan2_phy>;
> + status = "okay";
> +};
> +
> +&flexcan4 {
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_flexcan4>;
> + phys = <&flexcan4_phy>;
> + status = "okay";
> +};
> +
> &lpi2c3 {
> clock-frequency = <400000>;
> pinctrl-0 = <&pinctrl_lpi2c3>;
> @@ -431,6 +461,19 @@ &sai3 {
> };
>
> &scmi_iomuxc {
> + pinctrl_flexcan2: flexcan2grp {
> + fsl,pins = <
> + IMX94_PAD_GPIO_IO34__CAN2_TX 0x39e
> + IMX94_PAD_GPIO_IO35__CAN2_RX 0x39e
> + >;
> + };
> +
> + pinctrl_flexcan4: flexcan4grp {
> + fsl,pins = <
> + IMX94_PAD_GPIO_IO36__CAN4_TX 0x39e
> + IMX94_PAD_GPIO_IO37__CAN4_RX 0x39e
> + >;
> + };
>
> pinctrl_ioexpander_int2: ioexpanderint2grp {
> fsl,pins = <
>
> ---
> base-commit: 187dac290bfd0741b9d7d5490af825c33fd9baa4
> change-id: 20251118-dts-ad4bd4fdacd6
>
> Best regards,
> --
> Haibo Chen <haibo.chen@....com>
>
Powered by blists - more mailing lists