linux-kernel - Re: [PATCH 1/1] docs: makefile: move rustdoc check to the build wrapper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87seeb47pk.fsf@trenco.lwn.net>
Date: Tue, 18 Nov 2025 09:38:15 -0700
From: Jonathan Corbet <corbet@....net>
To: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Miguel Ojeda
 <miguel.ojeda.sandonis@...il.com>
Cc: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>, Linux Doc Mailing
 List <linux-doc@...r.kernel.org>, Alex Gaynor <alex.gaynor@...il.com>,
 Alice Ryhl <aliceryhl@...gle.com>, Andreas Hindborg
 <a.hindborg@...nel.org>, Benno Lossin <lossin@...nel.org>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Boqun Feng <boqun.feng@...il.com>, Danilo
 Krummrich <dakr@...nel.org>, Gary Guo <gary@...yguo.net>, Mauro Carvalho
 Chehab <mchehab@...nel.org>, Miguel Ojeda <ojeda@...nel.org>, Trevor Gross
 <tmgross@...ch.edu>, linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH 1/1] docs: makefile: move rustdoc check to the build
 wrapper

Mauro Carvalho Chehab <mchehab+huawei@...nel.org> writes:

> On Mon, Nov 17, 2025 at 10:20:46AM +0100, Miguel Ojeda wrote:
>> On Mon, Nov 17, 2025 at 10:13 AM Mauro Carvalho Chehab
>> <mchehab+huawei@...nel.org> wrote:
>> >
>> > The makefile logic to detect if rust is enabled is not working
>> > the way it was expected. Move it to be inside the wrapper
>> > script.
>> 
>> Hmm... Could the commit explain a bit why this didn't work and why now it does?
>
> I don't know exactly why this was not working.

I would feel a lot better if we knew what the real problem is before
applying fixes for it.  Otherwise something seems certain to come and
bite us at some point.

Thanks,

jon