linux-kernel - Re: [PATCH net-next 2/2] net: phy: mxl-gpy: add MxL862xx support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5ba651a4-4d66-4ab9-b253-95995e8a42bd@lunn.ch>
Date: Tue, 18 Nov 2025 17:44:17 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Daniel Golle <daniel@...rotopia.org>
Cc: Xu Liang <lxu@...linear.com>, Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: phy: mxl-gpy: add MxL862xx support

On Tue, Nov 18, 2025 at 02:43:55AM +0000, Daniel Golle wrote:
> On Tue, Nov 11, 2025 at 02:32:38AM +0100, Andrew Lunn wrote:
> > On Mon, Nov 10, 2025 at 10:35:00PM +0000, Daniel Golle wrote:
> > > Add PHY driver support for Maxlinear 86252 and 86282 switches.
> > > The PHYs built-into those switches are just like any other GPY 2.5G PHYs
> > > with the exception of the temperature sensor data being encoded in a
> > > different way.
> > 
> > Is there a temperature sensor per PHY, or just one for the whole
> > package?
> > 
> > Marvell did something similar for there SoHo switches. The temperature
> > sensor is mapped to each of internal PHYs register space, but in fact
> > there is a single sensor, not one per PHY.
> 
> It very much looks like it is also done in the way your are describing.
> The temperature reading on all 8 PHYs is almost exactly the same, even
> if eg. port 1 and 2 are connected to 2.5G link partners and doing some
> traffic and all other ports are disconnected the temperature stays the
> same value for all of them.
> 
> Should this hence be implemented as a single sensor of the phy package?

If you have a PHY packages, why not.

For the Marvell PHYs, so such thing existed. All we see is individual
PHYs. And the registers are the same for discrete devices. So it was
simpler to just export what is effectively the same senor multiple
times.

	Andrew