linux-kernel - Re: [PATCH] HID: mcp2221: fix slab out-of-bounds in mcp2221_raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s9n4rooq-o7o8-o470-9028-q841574n0q9s@xreary.bet>
Date: Tue, 18 Nov 2025 18:03:04 +0100 (CET)
From: Jiri Kosina <jikos@...nel.org>
To: Atharv Dubey <atharvd440@...il.com>
cc: bentiss@...nel.org, linux-input@...r.kernel.org, 
    linux-kernel@...r.kernel.org, 
    syzbot+1018672fe70298606e5f@...kaller.appspotmail.com
Subject: Re: [PATCH] HID: mcp2221: fix slab out-of-bounds in
 mcp2221_raw_event

On Mon, 3 Nov 2025, Atharv Dubey wrote:

> Fixes an out-of-bounds read triggered by malformed HID input reports.
> 
> Fixes: 3a8660878839 ("HID: mcp2221: add support for MCP2221 HID adapter")

The commit hash and the commit name don't match.

3a8660878839 is a Makefile update to reflect new kernel version, and 
commit with shortlog "HID: mcp2221: add support for MCP2221 HID adapter" 
doesn't seem to exist ...

> Reported-by: syzbot+1018672fe70298606e5f@...kaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=1018672fe70298606e5f
> Signed-off-by: Atharv Dubey <atharvd440@...il.com>
> ---
>  drivers/hid/hid-mcp2221.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-mcp2221.c b/drivers/hid/hid-mcp2221.c
> index a9fd7648515d..c97f0acbac8b 100644
> --- a/drivers/hid/hid-mcp2221.c
> +++ b/drivers/hid/hid-mcp2221.c
> @@ -945,7 +945,7 @@ static int mcp2221_raw_event(struct hid_device *hdev,
>  		switch (data[1]) {
>  		case MCP2221_SUCCESS:
>  			if ((data[mcp->gp_idx] == MCP2221_ALT_F_NOT_GPIOV) ||
> -				(mcp->gp_idx > 0 &&data[mcp->gp_idx - 1] == MCP2221_ALT_F_NOT_GPIOV)) {

... nor does this code.

What tree is this patch against?

-- 
Jiri Kosina
SUSE Labs