linux-kernel - Re: [PATCH v1 0/7] ptp: ocp: A fix and refactoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <aRy84Cm8Wo84SIpo@ashevche-desk.local>
Date: Tue, 18 Nov 2025 20:37:20 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Vadim Fedorenko <vadim.fedorenko@...ux.dev>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Richard Cochran <richardcochran@...il.com>,
	Jonathan Lemon <jonathan.lemon@...il.com>,
	Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH v1 0/7] ptp: ocp: A fix and refactoring

On Wed, Nov 12, 2025 at 03:27:14PM +0000, Vadim Fedorenko wrote:
> On 11/11/2025 16:52, Andy Shevchenko wrote:
> 
> >    ptp: ocp: Sort headers alphabetically
> >    ptp: ocp: don't use "proxy" headers
> I don't see benefits of these 2 patches, what's the reason?

I may give these reasons:

1. Makes clear what headers are in use (avoids dups and improves long-term
maintenance experience).

2. Makes sure we don't "include everything". This might (slightly) improve
the module build time, but also shows that we use what we use.

There are patches in the history of the Linux kernel for both scenarios
in C files (yes, for the h files such a change is much more important).

...

TBH, the driver is written in a bad style, it has so-o-o many issues,
I even don't know where to start... Oh, wait.

-- 
With Best Regards,
Andy Shevchenko