linux-kernel - Re: [PATCH v1 1/1] Documentation: gpio: Add a compatibility and feature list for PCA953x

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRzBGhsLA_s1rJbM@smile.fi.intel.com>
Date: Tue, 18 Nov 2025 20:55:22 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Bagas Sanjaya <bagasdotme@...il.com>
Cc: Levente Révész <levente.revesz@...abs.com>,
	linux-gpio@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v1 1/1] Documentation: gpio: Add a compatibility and
 feature list for PCA953x

On Sat, Nov 15, 2025 at 08:25:54AM +0700, Bagas Sanjaya wrote:
> On Wed, Nov 12, 2025 at 11:48:20PM +0100, Andy Shevchenko wrote:

When answering to the long email, please remove unrelated context.
Thanks.

...

> > +I went through all the datasheets and created this note listing
> > +chip functions and register layouts.
> 
> Nit: above first-person intro can be instead edited to:
> 
> This document lists chip functions and register layouts for all chips
> supported by PCA953x driver.

I believe it's fine to leave author's original text here. Also the proposed
version is not so clear how these document was assembled.

...

> > +.. note::
> > +     This is followed by all supported chips, except by pcal6534.
> 
> Do you mean aforementioned banks offset arrangement?

Yes. The chapters are per the stuff explained in them, so everything in one
chapter or section is related to the entire chapter or section.

...

> The rest LGTM.

Thank your for looking into this.


-- 
With Best Regards,
Andy Shevchenko