linux-kernel - Re: [EXTERNAL] [PATCH v1 1/2] ALSA: hda/tas2781: fix speaker id retrieval for multiple probes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c0d8c96c51c4265aa150ed8c4d785c7@ti.com>
Date: Tue, 18 Nov 2025 02:31:32 +0000
From: "Xu, Baojun" <baojun.xu@...com>
To: Antheas Kapenekakis <lkml@...heas.dev>, "Ding, Shenghao"
	<shenghao-ding@...com>
CC: Takashi Iwai <tiwai@...e.com>, "linux-sound@...r.kernel.org"
	<linux-sound@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "stable@...r.kernel.org"
	<stable@...r.kernel.org>
Subject: Re: [EXTERNAL] [PATCH v1 1/2] ALSA: hda/tas2781: fix speaker id
 retrieval for multiple probes

> 
> ________________________________________
> From: Antheas Kapenekakis <lkml@...heas.dev>
> Sent: 27 October 2025 03:16
> To: Ding, Shenghao; Xu, Baojun
> Cc: Takashi Iwai; linux-sound@...r.kernel.org; linux-kernel@...r.kernel.org; Antheas Kapenekakis; stable@...r.kernel.org
> Subject: [EXTERNAL] [PATCH v1 1/2] ALSA: hda/tas2781: fix speaker id retrieval for multiple probes
> 
> Currently, on ASUS projects, the TAS2781 codec attaches the speaker GPIO
> to the first tasdevice_priv instance using devm. This causes
> tas2781_read_acpi to fail on subsequent probes since the GPIO is already
> managed by the first device. This causes a failure on Xbox Ally X,
> because it has two amplifiers, and prevents us from quirking both the
> Xbox Ally and Xbox Ally X in the realtek codec driver.
> 
> It is unnecessary to attach the GPIO to a device as it is static.
> Therefore, instead of attaching it and then reading it when loading the
> firmware, read its value directly in tas2781_read_acpi and store it in
> the private data structure. Then, make reading the value non-fatal so
> that ASUS projects that miss a speaker pin can still work, perhaps using
> fallback firmware.
> 
> Fixes: 4e7035a75da9 ("ALSA: hda/tas2781: Add speaker id check for ASUS projects")
> Cc: stable@...r.kernel.org # 6.17
> Signed-off-by: Antheas Kapenekakis <lkml@...heas.dev>
> ---
>  include/sound/tas2781.h                       |  2 +-
>  .../hda/codecs/side-codecs/tas2781_hda_i2c.c  | 44 +++++++++++--------
>  2 files changed, 26 insertions(+), 20 deletions(-)
> 
Reviewed-by: Baojun Xu <baojun.xu@...com>

Best Regards
Jim