linux-kernel - Re: [PATCH v2] of/irq: Ignore interrupt parent for nodes without interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1a4d2276-75e1-4aa0-8ff2-c932ce5d6edc@kernel.org>
Date: Tue, 18 Nov 2025 20:55:14 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Mark Brown <broonie@...nel.org>,
 Geert Uytterhoeven <geert+renesas@...der.be>
Cc: Rob Herring <robh@...nel.org>, Saravana Kannan <saravanak@...gle.com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Paul Walmsley <pjw@...nel.org>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Alexandre Ghiti <alex@...ti.fr>, Samuel Holland <samuel@...lland.org>,
 Marc Zyngier <maz@...nel.org>,
 Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
 Magnus Damm <magnus.damm@...il.com>, devicetree@...r.kernel.org,
 linux-renesas-soc@...r.kernel.org, linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH v2] of/irq: Ignore interrupt parent for nodes without
 interrupts

On 18/11/2025 20:34, Mark Brown wrote:
> On Fri, Nov 14, 2025 at 11:47:54AM +0100, Geert Uytterhoeven wrote:
>> The Devicetree Specification states:
>>
>>     The root of the interrupt tree is determined when traversal of the
>>     interrupt tree reaches an interrupt controller node without an
>>     interrupts property and thus no explicit interrupt parent.
>>
>> However, of_irq_init() gratuitously assumes that a node without
>> interrupts has an actual interrupt parent if it finds an
>> interrupt-parent property higher up in the device tree.  Hence when such
>> a property is present (e.g. in the root node), the root interrupt
>> controller may not be detected as such, causing a panic:
> 
> I'm seeing a boot regression on the TI x15 platform in -next which
> bisects to this patch in -next, unfortunately even with earlycon (though
> just earlycon, I don't know the platform specific runes) the board just
> dies with no output:
> 
>   https://validation.linaro.org/scheduler/job/4252918#L409
> 
> It does seem like a plausible patch for this sort of issue though, and
> the bisect converges smoothly:


All Samsung platforms fail as well. I was waiting with bisection but
Marek was as usually very fast:

https://lore.kernel.org/all/20251118115037.1866871-1-m.szyprowski@samsung.com/

Best regards,
Krzysztof