linux-kernel - Re: [PATCH] scsi: target: reset t_task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d8d6830a-76f9-46d8-8643-69aec7ffb399@oracle.com>
Date: Tue, 18 Nov 2025 13:57:31 -0600
From: Mike Christie <michael.christie@...cle.com>
To: Ваторопин Андрей
 <a.vatoropin@...t.ru>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: Sudhakar Panneerselvam <sudhakar.panneerselvam@...cle.com>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lvc-project@...uxtesting.org" <lvc-project@...uxtesting.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>
Subject: Re: [PATCH] scsi: target: reset t_task_cdb pointer in error case

On 11/18/25 2:42 AM, Ваторопин Андрей wrote:
> From: Andrey Vatoropin <a.vatoropin@...t.ru>
> 
> If allocation of cmd->t_task_cdb fails, it remains NULL but is later
> dereferenced at the 'err' path.
> 
> In case of error reset NULL t_task_cdb value to point at the default
> fixed-size buffer.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: 9e95fb805dc0 ("scsi: target: Fix NULL pointer dereference")
> Cc: stable@...r.kernel.org
> Signed-off-by: Andrey Vatoropin <a.vatoropin@...t.ru>
> ---
>  drivers/target/target_core_transport.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c
> index 0a76bdfe5528..88544c911949 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -1524,6 +1524,7 @@ target_cmd_init_cdb(struct se_cmd *cmd, unsigned char *cdb, gfp_t gfp)
>  	if (scsi_command_size(cdb) > sizeof(cmd->__t_task_cdb)) {
>  		cmd->t_task_cdb = kzalloc(scsi_command_size(cdb), gfp);
>  		if (!cmd->t_task_cdb) {
> +			cmd->t_task_cdb = &cmd->__t_task_cdb[0];
>  			pr_err("Unable to allocate cmd->t_task_cdb"
>  				" %u > sizeof(cmd->__t_task_cdb): %lu ops\n",
>  				scsi_command_size(cdb),


Reviewed-by: Mike Christie <michael.christie@...cle.com>