linux-kernel - Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board 3/3S

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4e7bb5f5-30bb-4ed5-bb32-3008caa1826a@rootcommit.com>
Date: Tue, 18 Nov 2025 19:57:23 +0000 (UTC)
From: Michael Opdenacker <michael.opdenacker@...tcommit.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Heiko Stuebner <heiko@...ech.de>
Cc: michael.opdenacker@...tcommit.com, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org,
 linux-kernel@...r.kernel.org,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 1/2] dt-bindings: arm: rockchip: Add Asus Tinker Board
 3/3S

Hi Krzysztof

Thanks for the new review!

On 11/18/25 17:31, Krzysztof Kozlowski wrote:
> On 18/11/2025 16:56, Michael Opdenacker wrote:
>> Document the compatible strings for Asus Tinker Board 3 [1] and 3S [2],
>> which are SBCs based on the Rockchip 3566 SoC.
>>
>> The "3S" version ("S" for "storage") just adds a 16 GB eMMC
>> and a "mask ROM" DIP switch to the "3" version.
>>
>> [1] https://tinker-board.asus.com/series/tinker-board-3.html
>> [2] https://tinker-board.asus.com/series/tinker-board-3s.html
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@...tcommit.com>
>>
>> ---
>>
>> Changes in V3:
>>
>> - Remove this Acked-by as the binding code changed substantially:
>>    Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Above commit msg and DTS suggests they are pretty compatible with each
> other, so I don't quite get why this changed. Your changelog says
> "unexpectedly turns out to be compatible with 3 but not 3S.", but is
> this real or are you just guessing? I think you were tricked to change
> correct code into this.

I was just guessing.  The likelihood that something working on 3 doesn't 
work on 3s looks very small indeed, but I'm not the manufacturer to 
completely rule this out.
>
> Anyway, however odd this is, I don't care enough to stop this patchset, so:
>
> Acked-by: Krzysztof Kozlowski <krzk@...nel.org>

Thanks again!
Cheers
Michael.

-- 
Michael Opdenacker
Root Commit
Yocto Project and OpenEmbedded Training course - Learn by doing:
https://rootcommit.com/training/yocto/