linux-kernel - Re: [PATCH] scsi: qla2xxx: Fix improper freeing of purex item

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <45878638-8A5A-46E0-9223-BDDAD0C89362@gmail.com>
Date: Tue, 18 Nov 2025 12:44:24 -0800
From: himanshu Madhani <hmadhani2024@...il.com>
To: Zilin Guan <zilin@....edu.cn>
Cc: njavali@...vell.com,
 GR-QLogic-Storage-Upstream@...vell.com,
 "James.Bottomley@...senpartnership.com" <James.Bottomley@...senPartnership.com>,
 martin.petersen@...cle.com,
 linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 jianhao.xu@....edu.cn
Subject: Re: [PATCH] scsi: qla2xxx: Fix improper freeing of purex item



> On Nov 13, 2025, at 7:12 AM, Zilin Guan <zilin@....edu.cn> wrote:
> 
> In qla2xxx_process_purls_iocb(), an item is allocated via
> qla27xx_copy_multiple_pkt(), which internally calls
> qla24xx_alloc_purex_item().
> 
> The qla24xx_alloc_purex_item() function may return a pre-allocated item
> from a per-adapter pool for small allocations, instead of dynamically
> allocating memory with kzalloc().
> 
> An error handling path in qla2xxx_process_purls_iocb() incorrectly uses
> kfree() to release the item. If the item was from the pre-allocated pool,
> calling kfree() on it is a bug that can lead to memory corruption.
> 
> Fix this by using the correct deallocation function,
> qla24xx_free_purex_item(), which properly handles both dynamically
> allocated and pre-allocated items.
> 
> Fixes: 875386b988578 ("scsi: qla2xxx: Add Unsolicited LS Request and Response Support for NVMe")
> Signed-off-by: Zilin Guan <zilin@....edu.cn>
> ---
> drivers/scsi/qla2xxx/qla_nvme.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c
> index 316594aa40cc..42eb65a62f1f 100644
> --- a/drivers/scsi/qla2xxx/qla_nvme.c
> +++ b/drivers/scsi/qla2xxx/qla_nvme.c
> @@ -1292,7 +1292,7 @@ void qla2xxx_process_purls_iocb(void **pkt, struct rsp_que **rsp)
> a.reason = FCNVME_RJT_RC_LOGIC;
> a.explanation = FCNVME_RJT_EXP_NONE;
> xmt_reject = true;
> - kfree(item);
> + qla24xx_free_purex_item(item);
> goto out;
> }
> 
> -- 
> 2.34.1
> 
> 
Looks Good. 

Reviewed-by: Himanshu Madhani <hmadhani2024@...il.com <mailto:hmadhani2024@...il.com>>