linux-kernel - Re: [PATCH v3 5/5] dax: add PROBE_PREFER_ASYNCHRONOUS to the dax device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <691ce9acae44c_7a9a10020@iweiny-mobl.notmuch>
Date: Tue, 18 Nov 2025 15:48:28 -0600
From: Ira Weiny <ira.weiny@...el.com>
To: Michal Clapinski <mclapinski@...gle.com>, Dan Williams
	<dan.j.williams@...el.com>, Vishal Verma <vishal.l.verma@...el.com>, "Dave
 Jiang" <dave.jiang@...el.com>, <nvdimm@...ts.linux.dev>,
	<linux-cxl@...r.kernel.org>
CC: Pasha Tatashin <pasha.tatashin@...een.com>,
	<linux-kernel@...r.kernel.org>, Michal Clapinski <mclapinski@...gle.com>
Subject: Re: [PATCH v3 5/5] dax: add PROBE_PREFER_ASYNCHRONOUS to the dax
 device driver

Michal Clapinski wrote:
> Signed-off-by: Michal Clapinski <mclapinski@...gle.com>
> Reviewed-by: Dan Williams <dan.j.williams@...el.com>

Sorry for the delay.  I picked up this series but I find that this breaks
the device-dax and daxctl-create.sh.

I was able to fix device-dax with a sleep, see below.

I'm not 100% sure what to do about this.

I don't want to sprinkle sleeps around the tests.  daxctl-create.sh also
randomly fail due to the races introduced.  So not sure exactly where to
sprinkle them without more work.

Could dropping just this patch and landing the others achieve most of what
you need?

Ira

diff --git a/test/device-dax.c b/test/device-dax.c
index 49c9bc8b1748..817c76b0a88b 100644
--- a/test/device-dax.c
+++ b/test/device-dax.c
@@ -246,6 +246,7 @@ static int __test_device_dax(unsigned long align, int loglevel,
                goto out;
        }

+sleep(1);
        sprintf(path, "/dev/%s", daxctl_dev_get_devname(dev));
        fd = open(path, O_RDONLY);
        if (fd < 0) {