linux-kernel - Re: [PATCH v2 05/15] gpio: pxa: Use modern PM macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2ecpvm20y.fsf@free.fr>
Date: Tue, 18 Nov 2025 23:03:41 +0100
From: Robert Jarzmik <robert.jarzmik@...e.fr>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Jisheng Zhang <jszhang@...nel.org>,  Doug Berger <opendmb@...il.com>,
  Florian Fainelli <florian.fainelli@...adcom.com>,
  bcm-kernel-feedback-list@...adcom.com,  Linus Walleij
 <linus.walleij@...aro.org>,  Bartosz Golaszewski <brgl@...ev.pl>,  Hoan
 Tran <hoan@...amperecomputing.com>,  Andy Shevchenko <andy@...nel.org>,
  Daniel Palmer <daniel@...ngy.jp>,  Romain Perier
 <romain.perier@...il.com>,  Grygorii Strashko <grygorii.strashko@...com>,
  Santosh Shilimkar <ssantosh@...nel.org>,  Kevin Hilman
 <khilman@...nel.org>,  Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
  Masami Hiramatsu <mhiramat@...nel.org>,  Shubhrajyoti Datta
 <shubhrajyoti.datta@....com>,  Srinivas Neeli <srinivas.neeli@....com>,
  Michal Simek <michal.simek@....com>,  linux-gpio@...r.kernel.org,
  linux-arm-kernel@...ts.infradead.org,  linux-kernel@...r.kernel.org,
  linux-omap@...r.kernel.org
Subject: Re: [PATCH v2 05/15] gpio: pxa: Use modern PM macros

Andy Shevchenko <andy.shevchenko@...il.com> writes:

> On Tue, Nov 18, 2025 at 2:50 AM Jisheng Zhang 
> <jszhang@...nel.org> wrote:
>>
>> Use the modern PM macros for the suspend and resume functions 
>> to be
>> automatically dropped by the compiler when CONFIG_PM or
>> CONFIG_PM_SLEEP are disabled, without having to use #ifdef 
>> guards.
...zip...
>
>> -#ifdef CONFIG_PM
>>         unsigned long   saved_gplr;
>>         unsigned long   saved_gpdr;
>>         unsigned long   saved_grer;
>>         unsigned long   saved_gfer;
>> -#endif

Actually this is not equivalent to what was there before.

With Jisheng's patch, with CONFIG_PM disabled, he adds 16 bytes to 
the
structure. You might thing today, 16 bytes is nothing. True, but 
on a
64MB RAM devices, it's something.

That might not be a reason to reject the patch, but it's not only 
a
"modernisation patch".

Cheers.

--
Robert