linux-kernel - Re: [PATCH 0/2] pinctrl: s32cc: fix uninitialized memory issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYfNyAGdFpq=92UKBkScHq6U58N6XtwjJOJ3HAbBvFaNg@mail.gmail.com>
Date: Tue, 18 Nov 2025 23:56:58 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Jared Kangas <jkangas@...hat.com>
Cc: Dong Aisheng <aisheng.dong@....com>, Fabio Estevam <festevam@...il.com>, 
	Shawn Guo <shawnguo@...nel.org>, Jacky Bai <ping.bai@....com>, 
	Pengutronix Kernel Team <kernel@...gutronix.de>, NXP S32 Linux Team <s32@....com>, 
	Chester Lin <chester62515@...il.com>, Matthias Brugger <mbrugger@...e.com>, 
	Ghennadi Procopciuc <ghennadi.procopciuc@....nxp.com>, Bartosz Golaszewski <brgl@...ev.pl>, 
	linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] pinctrl: s32cc: fix uninitialized memory issues

On Tue, Nov 11, 2025 at 10:55 PM Jared Kangas <jkangas@...hat.com> wrote:

> This is a small series that fixes some uninitialized memory issues in
> pinctrl-s32cc. As an example of how these can affect the kernel, when
> probing i2c-imx, a memory allocation may fail because of the
> uninitialized memory giving a junk allocation size, which prevents chips
> on one of the I2C buses from being detected:
>
>         # i2cdetect -l
>         i2c-1   i2c             401ec000.i2c                            I2C adapter
>         i2c-2   i2c             402dc000.i2c                            I2C adapter
>         i2c-0   i2c             401e4000.i2c                            I2C adapter
>         # i2cdetect -y 0
>              0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f
>         00:          -- -- -- -- -- -- -- -- -- -- -- -- --
>         10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>         20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>         30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>         40: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>         50: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>         60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>         70: -- -- -- -- -- -- -- --
>
> Compared to when no failure occurs:
>
>         # i2cdetect -l
>         i2c-1   i2c             401ec000.i2c                            I2C adapter
>         i2c-2   i2c             402dc000.i2c                            I2C adapter
>         i2c-0   i2c             401e4000.i2c                            I2C adapter
>         # i2cdetect -y 0
>              0  1  2  3  4  5  6  7  8  9  a  b  c  d  e  f
>         00:          -- -- -- -- -- -- -- -- -- -- -- -- --
>         10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>         20: -- -- UU -- -- -- -- -- -- -- -- -- -- -- -- --
>         30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>         40: -- -- -- -- -- -- -- -- 48 -- -- -- -- -- -- --
>         50: -- 51 -- -- -- -- -- -- -- -- -- -- -- -- -- --
>         60: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
>         70: -- -- -- -- -- -- -- --
>
> Signed-off-by: Jared Kangas <jkangas@...hat.com>
> ---
> Jared Kangas (2):
>       pinctrl: s32cc: fix uninitialized memory in s32_pinctrl_desc
>       pinctrl: s32cc: initialize gpio_pin_config::list after kmalloc()

Patches applied for fixes!

Nice attention to detail here.

Yours,
Linus Walleij