linux-kernel - Re: [PATCH v2 1/2] objtool: fix the check for dead_end function with multiple sibliing calls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <qm6jwaqsgksrbx6ji44shd3wasogjxfrw6b6z7grgfxkhva3k5@efrjftvasm6c>
Date: Tue, 18 Nov 2025 15:29:51 -0800
From: Josh Poimboeuf <jpoimboe@...nel.org>
To: xur@...gle.com
Cc: Peter Zijlstra <peterz@...radead.org>, linux-kernel@...r.kernel.org, 
	Sriraman Tallam <tmsriram@...gle.com>, Han Shen <shenhan@...gle.com>, 
	Krzysztof Pszeniczny <kpszeniczny@...gle.com>
Subject: Re: [PATCH v2 1/2] objtool: fix the check for dead_end function with
 multiple sibliing calls

On Mon, Nov 03, 2025 at 09:52:43PM +0000, xur@...gle.com wrote:
> From: Rong Xu <xur@...gle.com>
> 
> If a function has multiple sibling calls, the dead_end check should
> only return true if all sibling call targets are also dead_end
> functions.
> 
> Signed-off-by: Rong Xu <xur@...gle.com>
> Reviewed-by: Sriraman Tallam <tmsriram@...gle.com>
> Reviewed-by: Han Shen <shenhan@...gle.com>
> Reviewed-by: Krzysztof Pszeniczny <kpszeniczny@...gle.com>
> ---
>  tools/objtool/check.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/objtool/check.c b/tools/objtool/check.c
> index 9004fbc067693..c2ee3c3a84a62 100644
> --- a/tools/objtool/check.c
> +++ b/tools/objtool/check.c
> @@ -314,7 +314,13 @@ static bool __dead_end_function(struct objtool_file *file, struct symbol *func,
>  				return false;
>  			}
>  
> -			return __dead_end_function(file, insn_func(dest), recursion+1);
> +			/*
> +			 * A function can have multiple sibling calls. All of
> +			 * them need to be dead ends for the function to be a
> +			 * dead end too.
> +			 */
> +			if (!__dead_end_function(file, insn_func(dest), recursion+1))
> +				return false;
>  		}
>  	}
>  

There's a typo in the subject "sibliing", and "fix" should be
capitalized:

  objtool: Fix the check for dead_end function with multiple sibling calls

Otherwise it LGTM.

Acked-by: Josh Poimboeuf <jpoimboe@...nel.org>

-- 
Josh