linux-kernel - Re: [PATCH libcrypto 1/2] array_size: introduce min_array

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHk-=wgkKPgsmcC0SFni7hhQM_b3qNjoyzw_JL2ZVs2eWXEZWQ@mail.gmail.com>
Date: Tue, 18 Nov 2025 15:32:31 -0800
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Eric Biggers <ebiggers@...nel.org>
Cc: "Jason A. Donenfeld" <Jason@...c4.com>, Ard Biesheuvel <ardb@...nel.org>, Kees Cook <kees@...nel.org>, 
	linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH libcrypto 1/2] array_size: introduce min_array_size()
 function decoration

On Tue, 18 Nov 2025 at 15:24, Eric Biggers <ebiggers@...nel.org> wrote:
>
> Anyway, I actually have a slight preference for just using 'static n'
> directly, without the unnecessary min_array_size() wrapper.  But if
> other people prefer min_array_size(), that's fine with me too.  At least
> this is what Linus asked for
> (https://lore.kernel.org/linux-crypto/CAHk-=wj6J5L5Y+oHc-i9BrDONpSbtt=iEemcyUm3dYnZ3pXxxg@mail.gmail.com/).

I wouldn't call that "asked for".

It was more a musing on how random that "static" syntax is and it's
likely incomprehensible to a lot of people - but also pointing out
that we already do have users of it, and saying that maybe it won't be
incomprehensible once we have a lot of users.

So I'm definitely not pushing for it.

But I do suspect it makes people understand what the code does more...

            Linus