linux-kernel - Re: [PATCH v1 1/3] pinctrl: intel: Refactor intel_gpio_add_pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251118052731.GC2912318@black.igk.intel.com>
Date: Tue, 18 Nov 2025 06:27:31 +0100
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
	Andy Shevchenko <andy@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v1 1/3] pinctrl: intel: Refactor
 intel_gpio_add_pin_ranges() to make it shorter

On Mon, Nov 17, 2025 at 06:06:16PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 17, 2025 at 1:27 PM Mika Westerberg
> <mika.westerberg@...ux.intel.com> wrote:
> > On Mon, Nov 17, 2025 at 08:56:59AM +0100, Andy Shevchenko wrote:
> 
> ...
> 
> > >       struct intel_pinctrl *pctrl = gpiochip_get_data(gc);
> > > +     struct device *dev = pctrl->dev;
> >
> > I prefer this keeping the reverse christmas tree.
> 
> And I prefer the logical split, if possible. putting it in between the
> intel_community and intel_paggroup lines seems worse to me than the
> proposed case.
> 
> > Also it can be const.
> 
> True, and it makes things closer to what you want if I leave it on the
> same line. Do you agree with my reasoning?

As long as it keeps the reverse chrismas tree after you add const.

> 
> > >       const struct intel_community *community;
> > >       const struct intel_padgroup *grp;
> > >       int ret;
> 
> -- 
> With Best Regards,
> Andy Shevchenko