linux-kernel - Re: [PATCH v3 3/4] nvme: Expose the tls_configured sysfs for secure concat connections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7a0343ee69331f1ade97b909cfd13a1ff04a09ae.camel@gmail.com>
Date: Tue, 18 Nov 2025 10:41:35 +1000
From: Wilfred Mallawa <wilfred.opensource@...il.com>
To: alistair23@...il.com, kbusch@...nel.org, axboe@...nel.dk, hch@....de, 
	sagi@...mberg.me, hare@...e.de, kch@...dia.com,
 linux-nvme@...ts.infradead.org
Cc: linux-kernel@...r.kernel.org, Alistair Francis <alistair.francis@....com>
Subject: Re: [PATCH v3 3/4] nvme: Expose the tls_configured sysfs for secure
 concat connections

On Fri, 2025-11-14 at 14:58 +1000, alistair23@...il.com wrote:
> From: Alistair Francis <alistair.francis@....com>
> 
> Signed-off-by: Alistair Francis <alistair.francis@....com>
> Reviewed-by: Christoph Hellwig <hch@....de>
> ---
> v3:
>  - No change
> v2:
>  - New patch
> 
>  drivers/nvme/host/sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nvme/host/sysfs.c b/drivers/nvme/host/sysfs.c
> index 29430949ce2f..6d10e12136d0 100644
> --- a/drivers/nvme/host/sysfs.c
> +++ b/drivers/nvme/host/sysfs.c
> @@ -838,7 +838,7 @@ static umode_t nvme_tls_attrs_are_visible(struct
> kobject *kobj,
>  	    !ctrl->opts->tls && !ctrl->opts->concat)
>  		return 0;
>  	if (a == &dev_attr_tls_configured_key.attr &&
> -	    (!ctrl->opts->tls_key || ctrl->opts->concat))
> +	    !ctrl->opts->concat)
>  		return 0;
>  	if (a == &dev_attr_tls_keyring.attr &&
>  	    !ctrl->opts->keyring)
Reviewed-by: Wilfred Mallawa <wilfred.mallawa@....com>

Wilfred