linux-kernel - Re: [PATCH] UFS: Make TM command timeout configurable from host side

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a89ccf64710deeadfce9cba08e28867f88463c77.camel@mediatek.com>
Date: Tue, 18 Nov 2025 05:55:49 +0000
From: Peter Wang (王信友) <peter.wang@...iatek.com>
To: "sh043.lee@...sung.com" <sh043.lee@...sung.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"bvanassche@....org" <bvanassche@....org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "martin.petersen@...cle.com"
	<martin.petersen@...cle.com>
Subject: Re: [PATCH] UFS: Make TM command timeout configurable from host side

On Mon, 2025-11-17 at 08:43 -0800, Bart Van Assche wrote:
> 
> There are no other SCSI drivers I know of that have a retry loop
> around
> the code that submits task management functions. I propose to reduce
> the
> retry count in this function from 100 to 1.
> 
> Thanks,
> 
> Bart.

Hi Bart and Seunghui,

Sorry, after thinking it through, under normal circumstances
it usually only loops once, so changing it to 30 is fine.
However, in extreme cases, it’s possible that after a 30-second 
timeout, the device just send a response, and at the same time, 
when the host receives the response, the IRQ is pending by system.
(other irq is executing or spin_lock_irq, etc)
So I suggest not changing this value, since it doesn’t affect 
the normal execution time. But in extreme cases, it could indeed 
fix an error.

Thanks
Peter