linux-kernel - Re: [PATCH RESEND v5 2/7] blk-mq-sched: unify elevators checking for async requests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <16e817ab-7444-4da8-bc92-38fa13cb407f@fnnas.com>
Date: Tue, 18 Nov 2025 13:56:40 +0800
From: "Yu Kuai" <yukuai@...as.com>
To: "Bart Van Assche" <bvanassche@....org>, <axboe@...nel.dk>, 
	<linux-block@...r.kernel.org>, <linux-kernel@...r.kernel.org>, 
	"Yu Kuai" <yukuai@...as.com>
Cc: <nilay@...ux.ibm.com>
Subject: Re: [PATCH RESEND v5 2/7] blk-mq-sched: unify elevators checking for async requests

Hi,

在 2025/11/18 7:35, Bart Van Assche 写道:
> On 11/15/25 7:52 PM, Yu Kuai wrote:
>> +static inline bool blk_mq_sched_sync_request(blk_opf_t opf)
>> +{
>> +    return op_is_sync(opf) && !op_is_write(opf);
>> +}
>
> The name of this function suggests that it performs an action while it
> only performs a test. Please consider renaming this function into e.g.
> blk_mq_is_sync_read(). I think the suggested name reflects much more
> clearly what this function does than "blk_mq_sched_sync_request()".
>
Yes, this sounds good.

> Thanks,
>
> Bart.
>

-- 
Thanks,
Kuai