linux-kernel - Re: [PATCH 2/3] xfs: move some code out of xfs_iget

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251118055929.GC22733@lst.de>
Date: Tue, 18 Nov 2025 06:59:29 +0100
From: Christoph Hellwig <hch@....de>
To: "Darrick J. Wong" <djwong@...nel.org>
Cc: Christoph Hellwig <hch@....de>, Carlos Maiolino <cem@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Luc Van Oostenryck <luc.vanoostenryck@...il.com>,
	Chris Li <sparse@...isli.org>, linux-sparse@...r.kernel.org,
	linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] xfs: move some code out of xfs_iget_recycle

On Fri, Nov 14, 2025 at 09:04:02AM -0800, Darrick J. Wong wrote:
> I wonder, does sparse get confused by rcu_read_lock having been taken by
> the caller but unlocked here?

Probably.  Plus the conditional trylock.  Note that the more complex
clang context tracking also didn't like it.