linux-kernel - Re: [PATCH v2] block/mq-deadline: Remove redundant hctx pointer dereferencing operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aRwNVAk1dnoJwYSZ@infradead.org>
Date: Mon, 17 Nov 2025 22:08:20 -0800
From: Christoph Hellwig <hch@...radead.org>
To: chengkaitao <pilgrimtao@...il.com>
Cc: axboe@...nel.dk, linux-block@...r.kernel.org,
	linux-kernel@...r.kernel.org, Chengkaitao <chengkaitao@...inos.cn>
Subject: Re: [PATCH v2] block/mq-deadline: Remove redundant hctx pointer
 dereferencing operation

On Tue, Nov 18, 2025 at 09:25:39AM +0800, chengkaitao wrote:
> From: Chengkaitao <chengkaitao@...inos.cn>
> 
> The value of 'hctx->queue' is already stored in '*q' within
> dd_insert_requests, we can directly reuse the result instead of
> dereferencing hctx again in the dd_insert_request function. This
> patch removes the redundant operation and modifies the function's
> parameters accordingly. We can eliminate an LDR instruction.

But you pass additional parameters on the stack.  Aka you're causing
churn here with bogus arguments.