lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <6017104c-740d-43db-bc53-58751ec57282@infradead.org>
Date: Mon, 17 Nov 2025 23:12:12 -0800
From: Randy Dunlap <rdunlap@...radead.org>
To: eanut 6 <jiakaipeanut@...il.com>, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: Jonathan Corbet <corbet@....net>, Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH] Documentation/admin-guide: fix typo in cscope command
 example

Hi,
[adding Shuah]

On 11/17/25 10:56 PM, eanut 6 wrote:
> The documentation previously had a typo:
>   c"scope -d -p10
> which would confuse users. This patch corrects it to:
>   cscope -d -p10
> 
> Signed-off-by: Jiakai Xu <jiakaiPeanut@...il.com>
> ---
>  Documentation/admin-guide/workload-tracing.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/admin-guide/workload-tracing.rst
> b/Documentation/admin-guide/workload-tracing.rst
> index d6313890ee41..dbdbed4a1b41 100644
> --- a/Documentation/admin-guide/workload-tracing.rst
> +++ b/Documentation/admin-guide/workload-tracing.rst
> @@ -196,7 +196,7 @@ Let’s checkout the latest Linux repository and
> build cscope database::
>    cscope -R -p10  # builds cscope.out database before starting browse session
>    cscope -d -p10  # starts browse session on cscope.out database

This makes the lines below agree with the 2 lines above,
so it looks good to me.

Acked-by: Randy Dunlap <rdunlap@...radead.org>

Could you also fix the comment below, please?

> > -Note: Run "cscope -R -p10" to build the database and c"scope -d -p10" to
> +Note: Run "cscope -R -p10" to build the database and "cscope -d -p10" to
>  enter into the browsing session. cscope by default cscope.out database.

                                           by default uses the cscope.out database.
(be careful not to go past 80 characters on that line)

>  To get out of this mode press ctrl+d. -p option is used to specify the
>  number of file path components to display. -p10 is optimal for browsing


thanks.
-- 
~Randy

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ