linux-kernel - Re: [PATCH v5 5/5] pci: Suspend iommu function prior to resetting a device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aRwraX2db2DPz7ez@Asurada-Nvidia>
Date: Tue, 18 Nov 2025 00:16:41 -0800
From: Nicolin Chen <nicolinc@...dia.com>
To: Bjorn Helgaas <helgaas@...nel.org>
CC: <joro@...tes.org>, <rafael@...nel.org>, <bhelgaas@...gle.com>,
	<alex@...zbot.org>, <jgg@...dia.com>, <kevin.tian@...el.com>,
	<will@...nel.org>, <robin.murphy@....com>, <lenb@...nel.org>,
	<baolu.lu@...ux.intel.com>, <linux-arm-kernel@...ts.infradead.org>,
	<iommu@...ts.linux.dev>, <linux-kernel@...r.kernel.org>,
	<linux-acpi@...r.kernel.org>, <linux-pci@...r.kernel.org>,
	<kvm@...r.kernel.org>, <patches@...ts.linux.dev>, <pjaroszynski@...dia.com>,
	<vsethi@...dia.com>, <etzhao1900@...il.com>
Subject: Re: [PATCH v5 5/5] pci: Suspend iommu function prior to resetting a
 device

On Mon, Nov 17, 2025 at 04:58:52PM -0600, Bjorn Helgaas wrote:
> On Mon, Nov 10, 2025 at 09:12:55PM -0800, Nicolin Chen wrote:
> > +int pci_reset_iommu_prepare(struct pci_dev *dev)
> > +{
> > +	if (pci_ats_supported(dev))
> > +		return iommu_dev_reset_prepare(&dev->dev);
> 
> Why bother checking pci_ats_supported() here?  That could be done
> inside iommu_dev_reset_prepare(), since iommu.c already uses
> dev_is_pci() and pci_ats_supported() is already exported outside
> drivers/pci/.

Ack. I will fix all of these.

Thanks for the review!
Nicolin