linux-kernel - Re: [PATCH] staging: iio: adt7316: replace sprintf() with sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34a55901fe0729145097d287a98746f23eea13d8.camel@gmail.com>
Date: Tue, 18 Nov 2025 08:18:28 +0000
From: Nuno Sá <noname.nuno@...il.com>
To: Jonathan Cameron <jic23@...nel.org>, Andy Shevchenko
	 <andy.shevchenko@...il.com>
Cc: Shi Hao <i.shihao.999@...il.com>, Michael.Hennerich@...log.com, 
	lars@...afoo.de, dlechner@...libre.com, nuno.sa@...log.com,
 andy@...nel.org, 	gregkh@...uxfoundation.org, linux-iio@...r.kernel.org, 
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: iio: adt7316: replace sprintf() with
 sysfs_emit()

On Sun, 2025-11-16 at 15:28 +0000, Jonathan Cameron wrote:
> On Sun, 16 Nov 2025 13:08:07 +0200
> Andy Shevchenko <andy.shevchenko@...il.com> wrote:
> 
> > On Sun, Nov 16, 2025 at 12:16 PM Shi Hao <i.shihao.999@...il.com> wrote:
> > > 
> > > Convert several sprintf() calls to sysfs_emit() in the
> > > sysfs show functions, as it is the preferred helper and
> > > prevents potential buffer overruns.
> > > 
> > > No functional changes intended.  
> > 
> > I briefly looked at it and see no issues,
> > Reviewed-by: Andy Shevchenko <andy@...nel.org>
> > 
> 
> Applied, but I will note that this driver is a long way from suitable
> for moving out of staging and I would be surprised if more than
> one or two of the lines changed in this patch make it through the
> necessary refactors (should anyone actually have another go at
> doing them).  Anyhow, I still think this is worth taking just to
> reduce the noise of remaining instances of this.
> 
> I'd have deleted this long ago except I actually have one somewhere
> and it one of the supported parts was still listed as suitable for
> new designs when I checked not long ago.

Seems to be now "just" in production. So no longer advised for new designs. I gave a
quick look and this is far from being a simple driver. It would require a fair amount
of work to bring it out of staging. So, are there users relying on staging drivers?
But I would assume that for staging we are still free to drop support it?

> 
> ADI folk, I would like to hear if we should just delete this one.

I guess Michael is the best person to answer this question.

- Nuno Sá