linux-kernel - Re: [PATCH v1] PM: sleep: core: Fix runtime PM enabling in device_resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <119e2410ca32a0d55fa6febf93c7a3164b391db0.camel@mediatek.com>
Date: Tue, 18 Nov 2025 16:31:08 +0800
From: Rose Wu <ya-jou.wu@...iatek.com>
To: "Rafael J. Wysocki" <rafael@...nel.org>, <linux-pm@...r.kernel.org>
CC: <rafael.j.wysocki@...el.com>, <regressions@...ts.linux.dev>,
	<linux-kernel@...r.kernel.org>, wsd_upstream <wsd_upstream@...iatek.com>,
	<linux-mediatek@...ts.infradead.org>, artis.chiu <artis.chiu@...iatek.com>,
	Johnny-cc.Kao <Johnny-cc.Kao@...iatek.com>, Ulf Hansson
	<ulf.hansson@...aro.org>
Subject: Re: [PATCH v1] PM: sleep: core: Fix runtime PM enabling in
 device_resume_early()

Hi,

On Mon, 2025-11-17 at 19:57 +0100, Rafael J. Wysocki wrote:
> 
> Make two changes to address this problem.
> 
> First, reorder device_suspend_late() to only disable runtime PM for a
> device if the power.is_late_suspended flag is going to be set for it.
> In all of the other cases, disabling runtime PM for the device is not
> in fact necessary.
> 
> Second, make device_resume_early() only enable runtime PM for the
> devices with the power.is_late_suspended flag set.
> 

My concern is with the error path in device_suspend_late().
If a device fails its dpm_run_callback(), it appears that its
power.is_late_suspended flag is not set, potentially leaving its runtime
PM disabled during the resume sequence.

Regards,
Rose