linux-kernel - Re: [PATCH] drm/panel: jadard-jd9365da-h3: Use dev_err_probe() instead of DRM_DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7e9016c-1c41-4860-b1a1-a6fb8661f72a@linaro.org>
Date: Tue, 18 Nov 2025 09:44:10 +0100
From: neil.armstrong@...aro.org
To: Abhishek Rajput <abhiraj21put@...il.com>, jagan@...eble.ai,
 jessica.zhang@....qualcomm.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/panel: jadard-jd9365da-h3: Use dev_err_probe()
 instead of DRM_DEV_ERROR() during probing

On 11/17/25 07:47, Abhishek Rajput wrote:
> The DRM_DEV_ERROR() has been deprecated, and use dev_err_probe()
> can be better. The other reason is that dev_err_probe() help avoid
> unexpected repeated err logs during defered probing.
> 
> Signed-off-by: Abhishek Rajput <abhiraj21put@...il.com>
> 
> diff --git a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> index 5c2530598ddb..aa05316dc57b 100644
> --- a/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> +++ b/drivers/gpu/drm/panel/panel-jadard-jd9365da-h3.c
> @@ -1132,22 +1132,19 @@ static int jadard_dsi_probe(struct mipi_dsi_device *dsi)
>   	dsi->lanes = desc->lanes;
>   
>   	jadard->reset = devm_gpiod_get(dev, "reset", GPIOD_OUT_HIGH);
> -	if (IS_ERR(jadard->reset)) {
> -		DRM_DEV_ERROR(&dsi->dev, "failed to get our reset GPIO\n");
> -		return PTR_ERR(jadard->reset);
> -	}
> +	if (IS_ERR(jadard->reset))
> +		return dev_err_probe(&dsi->dev, PTR_ERR(jadard->reset),
> +				"failed to get our reset GPIO\n");
>   
>   	jadard->vdd = devm_regulator_get(dev, "vdd");
> -	if (IS_ERR(jadard->vdd)) {
> -		DRM_DEV_ERROR(&dsi->dev, "failed to get vdd regulator\n");
> -		return PTR_ERR(jadard->vdd);
> -	}
> +	if (IS_ERR(jadard->vdd))
> +		return dev_err_probe(&dsi->dev, PTR_ERR(jadard->vdd),
> +				"failed to get vdd regulator\n");
>   
>   	jadard->vccio = devm_regulator_get(dev, "vccio");
> -	if (IS_ERR(jadard->vccio)) {
> -		DRM_DEV_ERROR(&dsi->dev, "failed to get vccio regulator\n");
> -		return PTR_ERR(jadard->vccio);
> -	}
> +	if (IS_ERR(jadard->vccio))
> +		return dev_err_probe(&dsi->dev, PTR_ERR(jadard->vccio),
> +				"failed to get vccio regulator\n");
>   
>   	ret = of_drm_get_panel_orientation(dev->of_node, &jadard->orientation);
>   	if (ret < 0)

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>