linux-kernel - Re: [PATCH 1/5] x86/insn-eval: Remove unused regs arg some functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251118084721.GK3245006@noisy.programming.kicks-ass.net>
Date: Tue, 18 Nov 2025 09:47:21 +0100
From: Peter Zijlstra <peterz@...radead.org>
To: Jiri Olsa <jolsa@...nel.org>
Cc: Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org,
	x86@...nel.org, Ingo Molnar <mingo@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>
Subject: Re: [PATCH 1/5] x86/insn-eval: Remove unused regs arg some functions

On Mon, Nov 17, 2025 at 10:31:32AM +0100, Jiri Olsa wrote:
> hi,
> regs argument is not used in several insn-eval functions, removing it.
> 
> I have some changes based on these functions and it feels wrong to pass
> NULL in regs argument. Also I don't want to send 5 extra patches with
> my other change, so sending this separately.
> 
> thanks,
> jirka
> 
> 
> ---
> Jiri Olsa (5):
>       x86/insn-eval: Remove regs arg from pt_regs_offset
>       x86/insn-eval: Remove regs arg from get_reg_offset
>       x86/insn-eval: Remove regs arg from insn_get_modrm_rm_off
>       x86/insn-eval: Remove regs arg from insn_get_modrm_reg_off
>       x86/insn-eval: Remove regs arg from get_reg_offset_16
> 
>  arch/x86/coco/sev/vc-handle.c    |  2 +-
>  arch/x86/include/asm/insn-eval.h |  6 +++---
>  arch/x86/kernel/cfi.c            |  2 +-
>  arch/x86/kernel/umip.c           |  2 +-
>  arch/x86/lib/insn-eval.c         | 35 +++++++++++++++--------------------
>  arch/x86/mm/extable.c            |  2 +-
>  6 files changed, 22 insertions(+), 27 deletions(-)

Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>