linux-kernel - Re: [PATCH] drbd: add missing kernel-doc for peer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHCkknrzdT1NkD1EGMPBGkamrg8fJY7Xu1GX6WjjPhquCyGQrg@mail.gmail.com>
Date: Tue, 18 Nov 2025 14:39:26 +0530
From: sukrut heroorkar <hsukrut3@...il.com>
To: Christoph Hellwig <hch@...radead.org>
Cc: Philipp Reisner <philipp.reisner@...bit.com>, Lars Ellenberg <lars.ellenberg@...bit.com>, 
	Christoph Böhmwalder <christoph.boehmwalder@...bit.com>, 
	Jens Axboe <axboe@...nel.dk>, "open list:DRBD DRIVER" <drbd-dev@...ts.linbit.com>, 
	"open list:BLOCK LAYER" <linux-block@...r.kernel.org>, open list <linux-kernel@...r.kernel.org>, 
	shuah@...nel.org, david.hunter.linux@...il.com
Subject: Re: [PATCH] drbd: add missing kernel-doc for peer_device parameter

On Tue, Nov 18, 2025 at 11:39 AM Christoph Hellwig <hch@...radead.org> wrote:
>
> On Mon, Nov 17, 2025 at 10:55:56PM +0530, Sukrut Heroorkar wrote:
> > W=1 build warns that peer_device is undocumented in the bitmap I/O
> > handlers. This parameter was introduced in commit 8164dd6c8ae1
> > ("drbd: Add peer device parameter to whole-bitmap I/O handlers"), but
> > the kernel-doc was not updated.
> >
> > Add the missing @peer_device entry.
>
> Or just make it a non-kerneldoc comment as it doesn't document an
> external API to start with.
>
Thank you. I have sent another patch adhering to this suggestion.