linux-kernel - Re: [PATCH] ovl: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOQ4uxh3YU-Ksx8gMA37YBXY-J=NnLDfTjfrdDYUU-1q3=SE7Q@mail.gmail.com>
Date: Tue, 18 Nov 2025 10:38:37 +0100
From: Amir Goldstein <amir73il@...il.com>
To: Chen Ni <nichen@...as.ac.cn>, Christian Brauner <brauner@...nel.org>
Cc: miklos@...redi.hu, linux-unionfs@...r.kernel.org, 
	linux-kernel@...r.kernel.org, NeilBrown <neil@...wn.name>
Subject: Re: [PATCH] ovl: remove unneeded semicolon

On Tue, Nov 18, 2025 at 3:48 AM Chen Ni <nichen@...as.ac.cn> wrote:
>
> Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
> semantic patch at scripts/coccinelle/misc/semicolon.cocci.
>
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  fs/overlayfs/dir.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/overlayfs/dir.c b/fs/overlayfs/dir.c
> index d21f81a524f6..7c2407b8c3a4 100644
> --- a/fs/overlayfs/dir.c
> +++ b/fs/overlayfs/dir.c
> @@ -105,7 +105,7 @@ static struct dentry *ovl_whiteout(struct ovl_fs *ofs)
>                         whiteout = dget(link);
>                 end_creating(link);
>                 if (!err)
> -                       return whiteout;;
> +                       return whiteout;
>
>                 if (err != -EMLINK) {
>                         pr_warn("Failed to link whiteout - disabling whiteout inode sharing(nlink=%u, err=%u)\n",
> --
> 2.25.1
>

Hi Chen,

Thank you for the report!

Which branch is this patch against? linux-next?

It fixes a typo that got in with this patch
https://lore.kernel.org/linux-fsdevel/20251113002050.676694-5-neilb@ownmail.net/

Currently staged on branch vfs-6.19.directory.locking in Christian's vfs tree.

Christian, do you want to squash this fix?

Thanks,
Amir.