linux-kernel - Re: [PATCH V2] workqueue: Process rescuer work items one-by-one using a positional marker

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJhGHyBeRDxtbfd4aZM0uQwarNNRpU27XQSCkweHB-hHQyDiEQ@mail.gmail.com>
Date: Tue, 18 Nov 2025 17:39:22 +0800
From: Lai Jiangshan <jiangshanlai@...il.com>
To: linux-kernel@...r.kernel.org
Cc: Lai Jiangshan <jiangshan.ljs@...group.com>, ying chen <yc1082463@...il.com>, 
	Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH V2] workqueue: Process rescuer work items one-by-one using
 a positional marker

Hello

On Tue, Nov 18, 2025 at 5:34 PM Lai Jiangshan <jiangshanlai@...il.com> wrote:

> ---
> Changed from v1:
>
> Insert the marker and use it purely as iteration marker as Tejun
> request.
>   It is hard to maintain the proper state of it, expecially maintaining
>   it only in pool->worklist which also requires an unlikely path in the
>   worker_thread() path.

It is hard to maintain the proper state of it if it is treated as a work
item as V1, especially maintaining it only in pool->worklist which
also requires an unlikely path in the worker_thread() path to
defeat the collision requeuing.

Thanks
Lai

>
> Add an unlikely path in the worker_thread() path(in assign_work()).
>
> Add other code in other place to make it not be treated like a work
> item.  I'm sure all the paths have been covered now, but I still feel
> a bit nevous about it for future changes.
>
> Extra the code to assign work in the rescuer_thread() out as
> assign_rescue_work().
>
> V1: https://lore.kernel.org/lkml/20251113163426.2950-1-jiangshanlai@gmail.com/
>