linux-kernel - Re: [PATCH v5 10/34] arm_mpam: Add probe/remove for mpam msc driver and kbuild boiler plate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d2b7980-db26-423f-9525-5d18eade8344@arm.com>
Date: Tue, 18 Nov 2025 10:44:25 +0000
From: Ben Horgan <ben.horgan@....com>
To: Markus Elfring <Markus.Elfring@....de>, James Morse
 <james.morse@....com>, linux-arm-kernel@...ts.infradead.org,
 linux-acpi@...r.kernel.org
Cc: LKML <linux-kernel@...r.kernel.org>,
 Amit Singh Tomar <amitsinght@...vell.com>,
 Baisheng Gao <baisheng.gao@...soc.com>,
 Baolin Wang <baolin.wang@...ux.alibaba.com>,
 Carl Worth <carl@...amperecomputing.com>,
 Catalin Marinas <catalin.marinas@....com>,
 D Scott Phillips <scott@...amperecomputing.com>,
 Danilo Krummrich <dakr@...nel.org>, Dave Martin <Dave.Martin@....com>,
 David Hildenbrand <david@...hat.com>, Drew Fustini <dfustini@...libre.com>,
 Fenghua Yu <fenghuay@...dia.com>, Gavin Shan <gshan@...hat.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Hanjun Guo <guohanjun@...wei.com>, Jamie Iles <quic_jiles@...cinc.com>,
 Jeremy Linton <jeremy.linton@....com>,
 Jonathan Cameron <Jonathan.Cameron@...wei.com>, Koba Ko <kobak@...dia.com>,
 Len Brown <lenb@...nel.org>, Linu Cherian <lcherian@...vell.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Peter Newman <peternewman@...gle.com>, "Rafael J. Wysocki"
 <rafael@...nel.org>, Rob Herring <robh@...nel.org>,
 Rohit Mathew <rohit.mathew@....com>,
 Shanker Donthineni <sdonthineni@...dia.com>,
 Shaopeng Tan <tan.shaopeng@...itsu.com>, Sudeep Holla
 <sudeep.holla@....com>, Wang ShaoBo <bobo.shaobowang@...wei.com>,
 Will Deacon <will@...nel.org>, Xin Hao <xhao@...ux.alibaba.com>,
 Zeng Heng <zengheng4@...wei.com>
Subject: Re: [PATCH v5 10/34] arm_mpam: Add probe/remove for mpam msc driver
 and kbuild boiler plate

Hi Markus,

On 11/17/25 19:50, Markus Elfring wrote:
> …
>> +++ b/drivers/resctrl/mpam_devices.c
>> @@ -0,0 +1,190 @@
> …
>> +static int mpam_msc_drv_probe(struct platform_device *pdev)
>> +{
> …
>> +	mutex_lock(&mpam_list_lock);
>> +	msc = do_mpam_msc_drv_probe(pdev);
>> +	mutex_unlock(&mpam_list_lock);
> …
> 
> Does anything hinder you to integrate statements like “guard(mutex)(&mpam_list_lock);” here?
> https://elixir.bootlin.com/linux/v6.18-rc6/source/include/linux/mutex.h#L228

The mpam_list_lock needs to be dropped before the end of the scope as it
is also taken in mpam_msc_drv_remove().

> 
> Regards,
> Markus

Thanks,

Ben