linux-kernel - Re: [PATCH] MIPS: kernel: Fix reservation for VDSO area

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAAhV-H7eoKgCWRVGWzgM55YOM9V8TRXe6Ax6-XQJF-STTpNpOg@mail.gmail.com>
Date: Tue, 18 Nov 2025 09:15:59 +0800
From: Huacai Chen <chenhuacai@...nel.org>
To: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc: Nam Cao <namcao@...utronix.de>, 
	Thomas Weißschuh <thomas.weissschuh@...utronix.de>, 
	Thomas Gleixner <tglx@...utronix.de>, linux-mips@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] MIPS: kernel: Fix reservation for VDSO area

Hi, Thomas,

I think 69896119dc9d ("MIPS: vdso: Switch to generic storage
implementation") changes the size of VDSO data from one page to
VDSO_NR_PAGES pages, so here we need to remove "top -= PAGE_SIZE".

Huacai

On Tue, Nov 18, 2025 at 3:19 AM Thomas Bogendoerfer
<tsbogend@...ha.franken.de> wrote:
>
> Commit 69896119dc9d ("MIPS: vdso: Switch to generic storage
> implementation") switches to a generic vdso storage, but missed to adapt
> the max stack top by the number of generic VDSO pages.
>
> Fixes: 69896119dc9d ("MIPS: vdso: Switch to generic storage implementation")
> Signed-off-by: Thomas Bogendoerfer <tsbogend@...ha.franken.de>
> ---
>  arch/mips/kernel/process.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/kernel/process.c b/arch/mips/kernel/process.c
> index 29191fa1801e..9eb5b26d4b5f 100644
> --- a/arch/mips/kernel/process.c
> +++ b/arch/mips/kernel/process.c
> @@ -693,6 +693,7 @@ unsigned long mips_stack_top(void)
>         if (current->thread.abi) {
>                 top -= PAGE_ALIGN(current->thread.abi->vdso->size);
>                 top -= PAGE_SIZE;
> +               top -= VDSO_NR_PAGES * PAGE_SIZE;
>                 top -= mips_gic_present() ? PAGE_SIZE : 0;
>
>                 /* Space to randomize the VDSO base */
> --
> 2.43.0
>
>