linux-kernel - Re: [PATCH 0/6] char/mwave: cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <b8834e5d-fdde-4b1a-8757-288dddc507a9@app.fastmail.com>
Date: Wed, 19 Nov 2025 13:54:54 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Jiri Slaby" <jirislaby@...nel.org>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6] char/mwave: cleanup

On Wed, Nov 19, 2025, at 10:19, Jiri Slaby (SUSE) wrote:
> Hi,
>
> the driver is in a bad shape -- this is a minimal cleanup, so that it is
> more or less readable.
>
> Jiri Slaby (SUSE) (6):
>   char/mwave: remove dead code
>   char/mwave: remove MWAVE_FUTZ_WITH_OTHER_DEVICES ifdeffery
>   char/mwave: remove unneeded fops
>   char/mwave: remove printk tracing
>   char/mwave: drop printk wrapper
>   char/mwave: drop typedefs

The cleanups all look good to me,

Acked-by: Arnd Bergmann <arnd@...db.de>

I assume you are not actually trying to use this driver, right?
According to thinkwiki.de, the 3780i modem was only used in a
couple of Thinkpad models that are now over 25 years old, using
Pentium II processors, and they all have a physical RS232 port
that can be used to connect an external modem instead.

Maybe we can just retire this driver?

     Arnd