linux-kernel - Re: platform/x86: acer-wmi: Enable SW_TABLET

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <ea6910ff-bcf9-7d38-b53f-6dc1f730c654@linux.intel.com>
Date: Wed, 19 Nov 2025 15:05:37 +0200 (EET)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Bastián Almendras <bastian.almendras96@...il.com>
cc: jlee@...e.com, platform-driver-x86@...r.kernel.org, 
    LKML <linux-kernel@...r.kernel.org>
Subject: Re: platform/x86: acer-wmi: Enable SW_TABLET_MODE on Switch One 10
 (SW1-011)

On Wed, 19 Nov 2025, Bastián Almendras wrote:

> Hello, good morning. I'm trying to get my old tablet working properly on Debian, but
> I've had to add some fixes.
> Here's a commit I created to add the SW_tablet_mode functionality to this tablet
> using acer-wmi.c.
> Add a DMI quirk for the SW1-011 setting force_caps to ACER_CAP_KBD_DOCK
> (these devices have no other acer-wmi based functionality).
> 
> Thank you very much for taking the time to read this.
> 
> Here's the diff: 
> 
> 704a705,713
> .callback = set_force_caps,
> .ident = "Acer Switch One SW1-011",
> .matches = {
> DMI_EXACT_MATCH(DMI_SYS_VENDOR, "Acer"),
> DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "Switch One SW1-011"),
> },
> .driver_data = (void *)ACER_CAP_KBD_DOCK,
> },
> {

Thanks but this email is not following our submission guidelines and is 
not formatted right.

Please take a look at Documentation/process/submitting-patches.rst

It might also help if you browse through a few submission from ML 
archives at lore.kernel.org to get a general idea how the submissions are 
formatted as that documention, while explaning some things in detail, 
doesn't give a overall example.

Also, if you use git format-patch command to create the patch, it produces 
the expected formatting by default.

(You don't need to be worried over not getting everything right on the 
next try, we're more than happy to guide you to towards the finish line 
once the formatting is roughly what is normally expected from a patch.)

-- 
 i.