linux-kernel - Re: [PATCH v1 2/3] VFS: Prepare atomic_open() for dentry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12F1DBD9-F5AB-46D5-97FB-1A85E530BE55@hammerspace.com>
Date: Wed, 19 Nov 2025 08:11:24 -0500
From: Benjamin Coddington <bcodding@...merspace.com>
To: NeilBrown <neil@...wn.name>
Cc: Alexander Viro <viro@...iv.linux.org.uk>,
 Christian Brauner <brauner@...nel.org>, Jan Kara <jack@...e.cz>,
 Chuck Lever <chuck.lever@...cle.com>, Jeff Layton <jlayton@...nel.org>,
 Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>,
 Tom Talpey <tom@...pey.com>, linux-fsdevel@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org,
 Trond Myklebust <trondmy@...nel.org>, Mike Snitzer <snitzer@...nel.org>
Subject: Re: [PATCH v1 2/3] VFS: Prepare atomic_open() for dentry_create()

On 18 Nov 2025, at 20:32, NeilBrown wrote:

> On Wed, 19 Nov 2025, Benjamin Coddington wrote:
>> The next patch allows dentry_create() to call atomic_open(), but it does
>> not have fabricated nameidata.  Let atomic_open() take a path instead.
>
> I think this commit message could usefully be longer and more details.
>
>  atomic_open() currently takes a nameidata of which it only uses the
>  path and the flags.  Flags are only used to update open_flags.  That
>  update can happen before atomic_open() is called which would mean that
>  only the path need be passed to atomic_open() rather than the whole
>  nameidata.  This will make it easier for dentry_create() To call
>  atomic_open().

Thank you!  I'll add this.

Ben