linux-kernel - Re: [PATCH 2/2] amd/iommu: Make protection domain ID functions non-static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251119134703.GA135560@nvidia.com>
Date: Wed, 19 Nov 2025 09:47:03 -0400
From: Jason Gunthorpe <jgg@...dia.com>
To: Sairaj Kodilkar <sarunkod@....com>
Cc: iommu@...ts.linux.dev, linux-kernel@...r.kernel.org, joro@...tes.org,
	suravee.suthikulpanit@....com, vasant.hegde@....com,
	ashish.kalra@....com, robin.murphy@....com, will@...nel.org
Subject: Re: [PATCH 2/2] amd/iommu: Make protection domain ID functions
 non-static

On Fri, Nov 14, 2025 at 04:14:42PM +0530, Sairaj Kodilkar wrote:
> So that both iommu.c and init.c can utilize them. Also define a new
> function 'pdom_id_destroy()' to destroy 'pdom_ids' instead of directly
> calling ida functions.
> 
> Signed-off-by: Sairaj Kodilkar <sarunkod@....com>
> ---
>  drivers/iommu/amd/amd_iommu.h |  5 +++++
>  drivers/iommu/amd/init.c      |  7 ++-----
>  drivers/iommu/amd/iommu.c     | 27 ++++++++++++++++++---------
>  3 files changed, 25 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/iommu/amd/amd_iommu.h b/drivers/iommu/amd/amd_iommu.h
> index 25044d28f28a..6335b577f80d 100644
> --- a/drivers/iommu/amd/amd_iommu.h
> +++ b/drivers/iommu/amd/amd_iommu.h
> @@ -173,6 +173,11 @@ static inline struct protection_domain *to_pdomain(struct iommu_domain *dom)
>  bool translation_pre_enabled(struct amd_iommu *iommu);
>  int __init add_special_device(u8 type, u8 id, u32 *devid, bool cmd_line);
>  
> +int amd_iommu_pdom_id_alloc(void);
> +int amd_iommu_pdom_id_reserve(int id);
> +void amd_iommu_pdom_id_free(int id);
> +void amd_iommu_pdom_id_destroy(void);

Domain IDs are not signed integers. Use u32.

> diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c
> index 48bca4dc8eb6..4d57e820b824 100644
> --- a/drivers/iommu/amd/iommu.c
> +++ b/drivers/iommu/amd/iommu.c
> @@ -1785,17 +1785,26 @@ int amd_iommu_complete_ppr(struct device *dev, u32 pasid, int status, int tag)
>   * contain.
>   *
>   ****************************************************************************/
> -
> -static int pdom_id_alloc(void)
> +int amd_iommu_pdom_id_alloc(void)
>  {
>  	return ida_alloc_range(&pdom_ids, 1, MAX_DOMAIN_ID - 1, GFP_ATOMIC);
>  }
>
> -static void pdom_id_free(int id)
> +int amd_iommu_pdom_id_reserve(int id)
> +{
> +	return ida_alloc_range(&pdom_ids, id, id, GFP_ATOMIC);
> +}

The GFP should probably be passed in as a function argument

Jason