linux-kernel - Re: [PATCH v3 2/2] gpio: adg1712: add driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZmHbYY3kCJN7d0-pkPmHs2xHHgF8VzarPFjL2kMmVm=A@mail.gmail.com>
Date: Wed, 19 Nov 2025 14:59:44 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Bartosz Golaszewski <brgl@...ev.pl>, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH v3 2/2] gpio: adg1712: add driver support

On Mon, Nov 17, 2025 at 10:15 AM Antoniu Miclaus
<antoniu.miclaus@...log.com> wrote:

> Add driver support for the ADG1712, which contains four independent
> single-pole/single-throw (SPST) switches and operates with a
> low-voltage single supply range from +1.08V to +5.5V or a low-voltage
> dual supply range from ±1.08V to ±2.75V.
>
> The driver configures switches once at probe time based on device tree
> properties and does not expose any userspace interface for runtime control.
>
> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@...log.com>
> ---
> Changes in v3:
> - Remove GPIO controller interface
> - Configure switches from device tree at probe time only
> - Add 'switch-states' property parsing
> - Change from GPIOD_ASIS to GPIOD_OUT_LOW

If you do it this way, as Bartosz says this is not a GPIO driver anymore.

Create drivers/switch and discuss with Greg how to proceed with the new
subsystem if you want to take this approach (and maybe eventually
create a userspace ABI).

What I've said about using the GPIO subsystem for this (which may be
OK if there is some consensus around it) can be found here:

https://lore.kernel.org/linux-gpio/CACRpkdZf9D2PH5AR46Pwi8UoyfwumKS4P3ncJ=RN4iu_cJzZ5w@mail.gmail.com/

and here:

https://lore.kernel.org/linux-gpio/CACRpkdbZgxWaf7B7vwD3n-OSbt8h8vGKQ_CmB_SNjDG6aXHayA@mail.gmail.com/

Yours,
Linus Walleij