linux-kernel - Re: [PATCH] phy: broadcom: bcm63xx-usbh: fix section mismatches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <461244a1-3bc1-478f-b97f-b0607375e596@linaro.org>
Date: Wed, 19 Nov 2025 16:07:28 +0100
From: Neil Armstrong <neil.armstrong@...aro.org>
To: Johan Hovold <johan@...nel.org>, Vinod Koul <vkoul@...nel.org>,
 Kishon Vijay Abraham I <kishon@...nel.org>
Cc: linux-phy@...ts.infradead.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org, Álvaro Fernández Rojas
 <noltari@...il.com>
Subject: Re: [PATCH] phy: broadcom: bcm63xx-usbh: fix section mismatches

On 10/17/25 07:45, Johan Hovold wrote:
> Platform drivers can be probed after their init sections have been
> discarded (e.g. on probe deferral or manual rebind through sysfs) so the
> probe function and match table must not live in init.
> 
> Fixes: 783f6d3dcf35 ("phy: bcm63xx-usbh: Add BCM63xx USBH driver")
> Cc: stable@...r.kernel.org	# 5.9
> Cc: Álvaro Fernández Rojas <noltari@...il.com>
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>   drivers/phy/broadcom/phy-bcm63xx-usbh.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/phy/broadcom/phy-bcm63xx-usbh.c b/drivers/phy/broadcom/phy-bcm63xx-usbh.c
> index 647644de041b..29fd6791bae6 100644
> --- a/drivers/phy/broadcom/phy-bcm63xx-usbh.c
> +++ b/drivers/phy/broadcom/phy-bcm63xx-usbh.c
> @@ -375,7 +375,7 @@ static struct phy *bcm63xx_usbh_phy_xlate(struct device *dev,
>   	return of_phy_simple_xlate(dev, args);
>   }
>   
> -static int __init bcm63xx_usbh_phy_probe(struct platform_device *pdev)
> +static int bcm63xx_usbh_phy_probe(struct platform_device *pdev)
>   {
>   	struct device *dev = &pdev->dev;
>   	struct bcm63xx_usbh_phy	*usbh;
> @@ -432,7 +432,7 @@ static int __init bcm63xx_usbh_phy_probe(struct platform_device *pdev)
>   	return 0;
>   }
>   
> -static const struct of_device_id bcm63xx_usbh_phy_ids[] __initconst = {
> +static const struct of_device_id bcm63xx_usbh_phy_ids[] = {
>   	{ .compatible = "brcm,bcm6318-usbh-phy", .data = &usbh_bcm6318 },
>   	{ .compatible = "brcm,bcm6328-usbh-phy", .data = &usbh_bcm6328 },
>   	{ .compatible = "brcm,bcm6358-usbh-phy", .data = &usbh_bcm6358 },
> @@ -443,7 +443,7 @@ static const struct of_device_id bcm63xx_usbh_phy_ids[] __initconst = {
>   };
>   MODULE_DEVICE_TABLE(of, bcm63xx_usbh_phy_ids);
>   
> -static struct platform_driver bcm63xx_usbh_phy_driver __refdata = {
> +static struct platform_driver bcm63xx_usbh_phy_driver = {
>   	.driver	= {
>   		.name = "bcm63xx-usbh-phy",
>   		.of_match_table = bcm63xx_usbh_phy_ids,

Reviewed-by: Neil Armstrong <neil.armstrong@...aro.org>