linux-kernel - Re: [RFC net-next] eth: fbnic: use ring->page_pool instead of page->pp in fbnic_clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251118184850.068273c5@kernel.org>
Date: Tue, 18 Nov 2025 18:48:50 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Byungchul Park <byungchul@...com>
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mm@...ck.org, kernel_team@...ynix.com, harry.yoo@...cle.com,
 hawk@...nel.org, andrew+netdev@...n.ch, david@...hat.com,
 lorenzo.stoakes@...cle.com, Liam.Howlett@...cle.com, vbabka@...e.cz,
 ziy@...dia.com, willy@...radead.org, toke@...hat.com,
 asml.silence@...il.com, alexanderduyck@...com, kernel-team@...a.com,
 davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 mohsin.bashr@...il.com, almasrymina@...gle.com, jdamato@...tly.com
Subject: Re: [RFC net-next] eth: fbnic: use ring->page_pool instead of
 page->pp in fbnic_clean_twq1()

On Wed, 19 Nov 2025 11:45:46 +0900 Byungchul Park wrote:
> > @ring in this context is the Tx ring, but it's the Rx ring that has the
> > page_pool pointer. Each Rx+Tx queue pair has 6 rings in total. You need
> > the sub0/sub1 ring of the Rx queue from which the page came here.  
> 
> Thank you for the explanation.  I'd better make it in the following way
> rather than modifying the unfamiliar code.  Looks fine?

Yes, I think that's fine. Just please wrap the long lines at 80 chars
in networking.