linux-kernel - Re: [PATCH v2 resend] net: stmmac: add support for dwmac 5.20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aR3snSb1YUFh9Dwp@shell.armlinux.org.uk>
Date: Wed, 19 Nov 2025 16:13:17 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Maxime Coquelin <mcoquelin.stm32@...il.com>,
	Alexandre Torgue <alexandre.torgue@...s.st.com>,
	netdev@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 resend] net: stmmac: add support for dwmac 5.20

On Wed, Nov 19, 2025 at 11:35:26PM +0800, Jisheng Zhang wrote:
> The dwmac 5.20 IP can be found on some synaptics SoCs. 
> 
> The binding doc has been already upstreamed by
> commit 13f9351180aa ("dt-bindings: net: snps,dwmac: Add dwmac-5.20
> version")
> 
> So we just need to add a compatibility flag in dwmac generic driver.

Do we _need_ to add it to the generic driver? Do the platforms that are
using this really not need any additional code to support them?

Looking at all the DT that mention dwmac-5.20 in their compatible
strings, that is always after other compatibles that point to other
platform specific drivers.

So, can you point to a platform that doesn't have its own platform
glue, and would be functional when using the dwmac-generic driver?

For reference, the dts that refer to dwmac-5.20 are:

arch/arm64/boot/dts/renesas/r9a09g047.dtsi
arch/arm64/boot/dts/renesas/r9a09g056.dtsi
arch/arm64/boot/dts/renesas/r9a09g057.dtsi
arch/arm64/boot/dts/st/stm32mp251.dtsi
arch/arm64/boot/dts/st/stm32mp253.dtsi
arch/arm64/boot/dts/st/stm32mp233.dtsi
arch/arm64/boot/dts/st/stm32mp231.dtsi
arch/riscv/boot/dts/starfive/jh7110.dtsi

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!