linux-kernel - Re: [PATCH v7 01/13] printk: Avoid delaying messages that aren't solicited by any console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aR3mbH7A1xBBiux-@pathway.suse.cz>
Date: Wed, 19 Nov 2025 16:46:52 +0100
From: Petr Mladek <pmladek@...e.com>
To: Chris Down <chris@...isdown.name>
Cc: linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	John Ogness <john.ogness@...utronix.de>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	Tony Lindgren <tony.lindgren@...ux.intel.com>, kernel-team@...com
Subject: Re: [PATCH v7 01/13] printk: Avoid delaying messages that aren't
 solicited by any console

On Wed 2025-11-19 03:33:20, Chris Down wrote:
> Of course, one reviews the whole patch set and then misses...

I think that this is a classic post-sent panic ;-)

> Chris Down writes:
> > -	boot_delay_msec(level);
> > +	/* If the message is forced (e.g. panic), we must delay */
> 
> That should obviously say "_not_ delay". I'll fix it on next resend.

IMHO, the original message is correct. The message is forced => shown
 => the delay allows to read the message on a screen.

> > +	if (!is_printk_force_console() && suppress_message_printing(level))
> > +		return;
> > +
> > +	boot_delay_msec();

Best Regards,
Petr