linux-kernel - Re: [PATCH] fs/ntfs3: check for shutdown in fsync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202511191004.GdiCxONs-lkp@intel.com>
Date: Wed, 19 Nov 2025 10:51:02 +0800
From: kernel test robot <lkp@...el.com>
To: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>,
	ntfs3@...ts.linux.dev
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
Subject: Re: [PATCH] fs/ntfs3: check for shutdown in fsync

Hi Konstantin,

kernel test robot noticed the following build warnings:

[auto build test WARNING on brauner-vfs/vfs.all]
[also build test WARNING on linus/master v6.18-rc6 next-20251118]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Konstantin-Komarov/fs-ntfs3-check-for-shutdown-in-fsync/20251118-210835
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20251118130705.411336-1-almaz.alexandrovich%40paragon-software.com
patch subject: [PATCH] fs/ntfs3: check for shutdown in fsync
config: i386-buildonly-randconfig-004-20251119 (https://download.01.org/0day-ci/archive/20251119/202511191004.GdiCxONs-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251119/202511191004.GdiCxONs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202511191004.GdiCxONs-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> fs/ntfs3/file.c:1381:5: warning: no previous prototype for function 'ntfs_file_fsync' [-Wmissing-prototypes]
    1381 | int ntfs_file_fsync(struct file *file, loff_t start, loff_t end, int datasync)
         |     ^
   fs/ntfs3/file.c:1381:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
    1381 | int ntfs_file_fsync(struct file *file, loff_t start, loff_t end, int datasync)
         | ^
         | static 
   fs/ntfs3/file.c:1415:12: warning: initializer overrides prior initialization of this subobject [-Winitializer-overrides]
    1415 |         .fsync          = ntfs_file_fsync,
         |                           ^~~~~~~~~~~~~~~
   fs/ntfs3/file.c:1412:12: note: previous initialization is here
    1412 |         .fsync          = generic_file_fsync,
         |                           ^~~~~~~~~~~~~~~~~~
   2 warnings generated.


vim +/ntfs_file_fsync +1381 fs/ntfs3/file.c

  1377	
  1378	/*
  1379	 * ntfs_file_fsync - file_operations::fsync
  1380	 */
> 1381	int ntfs_file_fsync(struct file *file, loff_t start, loff_t end, int datasync)
  1382	{
  1383		struct inode *inode = file_inode(file);
  1384		if (unlikely(ntfs3_forced_shutdown(inode->i_sb)))
  1385			return -EIO;
  1386	
  1387		return generic_file_fsync(file, start, end, datasync);
  1388	}
  1389	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki