linux-kernel - Re: [PATCH v3 01/15] gpio: dwapb: Use modern PM macros

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aR3v9yv2tXPiDIwn@smile.fi.intel.com>
Date: Wed, 19 Nov 2025 18:27:35 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Jisheng Zhang <jszhang@...nel.org>
Cc: Andy Shevchenko <andy.shevchenko@...il.com>,
	Doug Berger <opendmb@...il.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	bcm-kernel-feedback-list@...adcom.com,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>,
	Hoan Tran <hoan@...amperecomputing.com>,
	Andy Shevchenko <andy@...nel.org>, Daniel Palmer <daniel@...ngy.jp>,
	Romain Perier <romain.perier@...il.com>,
	Grygorii Strashko <grygorii.strashko@...com>,
	Santosh Shilimkar <ssantosh@...nel.org>,
	Kevin Hilman <khilman@...nel.org>,
	Robert Jarzmik <robert.jarzmik@...e.fr>,
	Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Shubhrajyoti Datta <shubhrajyoti.datta@....com>,
	Srinivas Neeli <srinivas.neeli@....com>,
	Michal Simek <michal.simek@....com>, linux-gpio@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org
Subject: Re: [PATCH v3 01/15] gpio: dwapb: Use modern PM macros

On Thu, Nov 20, 2025 at 12:04:58AM +0800, Jisheng Zhang wrote:
> On Wed, Nov 19, 2025 at 06:11:53PM +0200, Andy Shevchenko wrote:
> > On Wed, Nov 19, 2025 at 6:09 PM Jisheng Zhang <jszhang@...nel.org> wrote:
> > > On Wed, Nov 19, 2025 at 05:42:59PM +0200, Andy Shevchenko wrote:
> > > > On Wed, Nov 19, 2025 at 10:43:13PM +0800, Jisheng Zhang wrote:

...

> > > > > -#ifdef CONFIG_PM_SLEEP
> > > > >     struct dwapb_context    *ctx;
> > > > > -#endif
> > > >
> > > > But why this? For the PM_SLEEP=n cases it will give an unrequested overhead.
> > >
> > > the pm_ptr() and pm_sleep_ptr() can optimize out the PM related
> > > functions, but those functions are still compiled, so if we keep the
> > > #ifdef, there will be build errors.
> > 
> > Is this an expectation or you can share the error, please?
> 
> drivers/gpio/gpio-dwapb.c: In function ‘dwapb_irq_set_wake’:
> drivers/gpio/gpio-dwapb.c:368:51: error: ‘struct dwapb_gpio_port’ h
> as no member named ‘ctx’
>   368 |         struct dwapb_context *ctx = gpio->ports[0].ctx;

Thank you!

I just answered in the other email that I will tag v4 after fixing typos
and dropping unrelated changes.


-- 
With Best Regards,
Andy Shevchenko