linux-kernel - Re: [PATCH v2 1/2] mfd: ls2kbmc: Fully convert to use managed resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251119164703.GU1949330@google.com>
Date: Wed, 19 Nov 2025 16:47:03 +0000
From: Lee Jones <lee@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Binbin Zhou <zhoubinbin@...ngson.cn>, linux-kernel@...r.kernel.org,
	Chong Qiao <qiaochong@...ngson.cn>
Subject: Re: [PATCH v2 1/2] mfd: ls2kbmc: Fully convert to use managed
 resources

On Thu, 13 Nov 2025, Andy Shevchenko wrote:

> The mixing of managed and non-managed resources may lead to possible
> use-after-free bugs. In this driver the problematic part is the device
> functionality that may just have gone behind the functions back, e.g.,
> when interrupt is being served. Fix this by switching to managed resources
> for PCI.
> 
> Fixes: 91a3e1f5453a ("mfd: ls2kbmc: Check for devm_mfd_add_devices() failure")
> Fixes: d952bba3fbb5 ("mfd: ls2kbmc: Add Loongson-2K BMC reset function support")
> Reviewed-by: Binbin Zhou <zhoubinbin@...ngson.cn>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/mfd/ls2k-bmc-core.c | 28 +++++++---------------------
>  1 file changed, 7 insertions(+), 21 deletions(-)

Still doesn't apply.  I'm getting lots of conflicts.

What base are you on?

% git --no-pager log --oneline drivers/mfd/ls2k-bmc-core.c
3696ac1d0db2 mfd: ls2kbmc: Remove unneeded semicolon from ls2k_bmc_recover_pci_data()
d952bba3fbb5 mfd: ls2kbmc: Add Loongson-2K BMC reset function support
0d64f6d1ffe9 mfd: ls2kbmc: Introduce Loongson-2K BMC core driver

-- 
Lee Jones [李琼斯]