linux-kernel - Re: [PATCH 10/28] mtd: spinand: Make use of the operation templates through SPINAND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87jyzmaqcq.fsf@bootlin.com>
Date: Wed, 19 Nov 2025 18:23:33 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: Mark Brown <broonie@...nel.org>,  Richard Weinberger <richard@....at>,
  Vignesh Raghavendra <vigneshr@...com>,  Pratyush Yadav
 <pratyush@...nel.org>,  Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
  Steam Lin <STLin2@...bond.com>,  Santhosh Kumar K <s-k6@...com>,
  linux-spi@...r.kernel.org,  linux-kernel@...r.kernel.org,
  linux-mtd@...ts.infradead.org
Subject: Re: [PATCH 10/28] mtd: spinand: Make use of the operation templates
 through SPINAND_OP()

On 05/11/2025 at 17:28:29 +01, Tudor Ambarus <tudor.ambarus@...aro.org> wrote:

> On 10/31/25 6:26 PM, Miquel Raynal wrote:
>> index 4afebaf5f0195b9bc617ea1f125f637f76fff9f8..a8fd04a67cfa9925bd68c57539d86e0816b76274 100644
>> --- a/include/linux/mtd/spinand.h
>> +++ b/include/linux/mtd/spinand.h
>> @@ -701,6 +701,93 @@ struct spinand_device {
>>  			     unsigned int retry_mode);
>>  };
>>  
>> +static inline struct spi_mem_op
>
> Do we still do inlines?

Defining functions in headers like that, I think yes? (static inline,
not just inline). The full line is something like:

+static inline struct spi_mem_op
+spinand_fill_reset_op(struct spinand_device *spinand)
+{

So it's not an inline declaration of a variable, but the definition of a
function (just saying, in case the diff mislead you).

Thanks,
Miquèl